Skip to content

MSC3882: Allow an existing session to sign in a new session - #3882

Merged
turt2live merged 18 commits into
mainfrom
hughns/login-token-requests
May 7, 2023
Merged

MSC3882: Allow an existing session to sign in a new session#3882
turt2live merged 18 commits into
mainfrom
hughns/login-token-requests

Conversation

@hughns

@hughns hughns commented Sep 5, 2022 •
edited by clokep
Loading

Copy link
Copy Markdown
Member

Rendered

Implementations of initial revision:

Implementations of revision 1:

FCP tickyboxes

@hughns hughns changed the title Allow an existing session to sign in a new session MSC3882: Allow an existing session to sign in a new session Sep 5, 2022
@hughns hughns added the A-Client Server Client-Server API label Sep 5, 2022
@turt2live turt2live added proposal A matrix spec change proposal. Process state. kind:maintenance MSC which clarifies/updates existing spec needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Sep 5, 2022
uhoreg
uhoreg reviewed Sep 5, 2022
View reviewed changes
Comment thread proposals/3882-login-token-request.md Outdated
@hughns
hughns marked this pull request as ready for review September 11, 2022 20:23
@hughns hughns mentioned this pull request Sep 20, 2022
Merged
4 tasks
@turt2live
turt2live requested review from a team and turt2live February 28, 2023 02:30
@turt2live
turt2live requested a review from a team March 7, 2023 04:25
@turt2live

ghost commented Mar 7, 2023 •
edited by turt2live
Loading

Copy link
Copy Markdown
Member

@matrix-org/security - authentication scares me: would you be able to take a look at this for technical design and security considerations please?

@matrix-org/spec-core-team - the author is looking for general technical design review on this one for the moment. It looks like there's also implementations provided: might be able to remove needs-implementation?

Correction: @matrix-org/spec-core-team - the author believes this is ready for FCP. Please review the MSC and implementation with that in mind, and @mscbot fcp merge if the MSC looks good to go.

davidegirardi
davidegirardi reviewed Mar 7, 2023
View reviewed changes
Comment thread proposals/3882-login-token-request.md Outdated
Comment thread proposals/3882-login-token-request.md Outdated
turt2live
turt2live approved these changes Mar 14, 2023
View reviewed changes

ghost left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall seems fine enough to move forward: just a few things to touch up concurrent to FCP.

@mscbot fcp merge

Comment thread proposals/3882-login-token-request.md Outdated
Comment thread proposals/3882-login-token-request.md Outdated
Comment thread proposals/3882-login-token-request.md Outdated
@turt2live

ghost commented Mar 14, 2023

Copy link
Copy Markdown
Member

hmm, alright then.

@mscbot fcp merge

@mscbot

ghost commented Mar 14, 2023 •
edited by anoadragon453
Loading

Copy link
Copy Markdown
Collaborator

Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people:

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the FCP. Process state. disposition-merge Process state. labels Mar 14, 2023
@turt2live turt2live mentioned this pull request May 19, 2023
Merged
@turt2live turt2live self-assigned this May 19, 2023
@turt2live

ghost commented May 19, 2023

Copy link
Copy Markdown
Member

Spec PR: matrix-org/matrix-spec#1530

@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed release-blocker spec-pr-missing MSC is accepted, but missing spec PR. Process state. labels May 19, 2023
@turt2live

ghost commented May 23, 2023

Copy link
Copy Markdown
Member

Merged 🎉

@turt2live turt2live added merged A proposal whose PR has merged into the spec! Process state. and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels May 23, 2023
This was referenced May 23, 2023
Closed
Merged
This was referenced May 24, 2023
Merged
Closed
@YamatoRyou YamatoRyou mentioned this pull request Jul 11, 2023
Closed
@S7evinK S7evinK mentioned this pull request Oct 2, 2023
Open
16 tasks
@Johennes Johennes mentioned this pull request Jul 12, 2024
Merged
3 tasks
This was referenced Sep 5, 2024
Closed
Merged
@Johennes Johennes mentioned this pull request Oct 8, 2024
Closed
44 tasks
@matrixbot matrixbot mentioned this pull request Nov 1, 2024
Open
16 tasks
@sumnerevans sumnerevans mentioned this pull request Dec 19, 2024
Merged
@anoadragon453 anoadragon453 mentioned this pull request Oct 8, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uhoreg uhoreg uhoreg left review comments
@richvdh richvdh richvdh left review comments
@turt2live turt2live turt2live approved these changes
@anoadragon453 anoadragon453 anoadragon453 approved these changes
+1 more reviewer
@davidegirardi davidegirardi davidegirardi left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@turt2live turt2live

Labels

A-Client Server Client-Server API kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! Process state. proposal A matrix spec change proposal. Process state.

Projects

Spec Core Team Workflow
Status: Merged/Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@hughns @turt2live @mscbot @uhoreg @anoadragon453 @richvdh @davidegirardi